this post was submitted on 29 Mar 2024
977 points (98.3% liked)

Programmer Humor

19551 readers
1038 users here now

Welcome to Programmer Humor!

This is a place where you can post jokes, memes, humor, etc. related to programming!

For sharing awful code theres also Programming Horror.

Rules

founded 1 year ago
MODERATORS
Feyter@programming.dev
anzo@programming.dev
BurningTurtle@programming.dev
pylapp@programming.dev
977
Review Please (programming.dev)
submitted 7 months ago by JPDev@programming.dev to c/programmer_humor@programming.dev
112 comments fedilink hide all child comments
 
you are viewing a single comment's thread
view the rest of the comments
[–] dan@upvote.au 1 points 7 months ago (1 children)

You can make a PR against your feature branch and have that reviewed

But what if you have multiple PRs that depend on each other? Or are you saying only have one PR open at a time? That sounds like it'd be very slow?

[–] iknowitwheniseeit@lemmynsfw.com 1 points 7 months ago (1 children)

I suppose it is possible to have two PR that have changes that depend on each other. In general this just requires refactoring... typically making a third PR removing the circular dependency.

It sounds like your policy is to keep PR around a long time, maybe? Generally we try to have ours merged within a few days, before bitrot sets in.

[–] dan@upvote.au 1 points 7 months ago

Sorry, my comment was unclear. I didn't mean a circular dependency, just PRs that have a chain of dependencies (e.g. PR 100 that depends on 99, that depends on 98, that depends on 97)

They're usually not around for a long time, but there can be relatively large chains if someone is quickly adding new features.