this post was submitted on 08 Jul 2023
649 points (98.7% liked)
Programmer Humor
32571 readers
171 users here now
Post funny things about programming here! (Or just rant about your favourite programming language.)
Rules:
- Posts must be relevant to programming, programmers, or computer science.
- No NSFW content.
- Jokes must be in good taste. No hate speech, bigotry, etc.
founded 5 years ago
MODERATORS
you are viewing a single comment's thread
view the rest of the comments
view the rest of the comments
Hello! I'm a hobbyist in this space (scripting/coding), does anyone here have a:
I never had a team or guide or mentor and when I saw this i felt that my commits are like smoke signals describing that there's a fire. which isnt really helpful.
I tried to contribute to a python module that I use daily, my PR was so over engineered (iirc i added just 3 lines, but with tests, screenshots, CI/CD) i think to compensate for my lack of experience that I got called out ("wow this is pretty extreme just for that feature").
https://www.conventionalcommits.org/en/v1.0.0/
We’re lucky in that the inventors of our technology are still alive (for the most part). So we can ask them: Linus Torvalds on git commit messages
This is really cool
The gold standard, as so often, is to consult an oracle able to tell you what questions you will be asking when looking at the comment or commit in the future. Then answer those questions and write them down.
In lieu of an oracle, use your experience and best judgement.
Oh and never write whole papers to explain what you're doing, unless you're actually writing a whole paper. Instead, drop a cheeky
doi;//URI as the only comment of the whole file to document that you're an experienced enough programmer to copy from papers instead of stack overflow.My personal cent: Some tools strongly suggest that your commit messages should not exceed 50 characters in the first line, and 80 characters on every other line. While the 80-character rule makes sense if you’re using a terminal (and someone on your team will even if you don’t), I strongly disagree with the 50-character rule. If you want to be in any way clear what you did, 50 characters is simply not enough even for the subject line.
The reason for the approximately 50 character limit is because there's many tools that display a single line and will truncate it if it's more than about that length (though really the point of truncation can vary wildly -- plenty of tools will let you go twice that before they cut you off). So if your one line summary is too long, it'll be cut off and harder to understand your commit at a glance.
You always can elaborate in a second paragraph, at any rate.
How much can you really put in 50 characters?
Fix: NPE in customer download component when users– That’s 50 characters. Should I not mention where I fixed the bug?Fix: NPE when users downloaded customers without s– I think I can get rid of the actor in some cases.̀ Fix: NPE when downloading customers without select`. The summary I want to give cannot be truncated any further.
Fix: NPE when downloading customers. This fits, but is so vague as to be pointless as a summary, in my view.I don’t follow the 50 character rule, but to answer your first question: imo, no, don’t mention where you fixed the bug. This is a commit message that is explicitly tied to the place where you fixed the bug. You can go into more detail in the PR if you need to.
“PR” lol. I’m the sole developer.
Jokes aside. I find it easier to have all the information in a commit message, so I can browse it in the git log without having to find the relevant PR(s) that finally merged it.
Fixes #23132: NPE when downloading customersReading that you see:
It's plenty to orient yourself in case you need to dig in, plenty so that you can skip over the commit if you're looking for something else, and short enough to ignore. If you absolutely need to document more, do it under the fold but that headline there is what should show up in a list of commits.