Well its public so who knows in what other package is using it. And it's static, so who know what kind if monster is calling it from some inapropriate place. I have seen static methods being called from translation/localization files, because "it works".

[–] mbtrhcs@feddit.org 15 points 2 months ago* (last edited 2 months ago) (1 children)

IntelliJ finds most uses in my experience unless you're doing something weird with reflection or similar. And if it's a public facing API only used by the library's consumers..– it should be used in tests at the very least! Especially if it's prone to regressions like the comment suggests

[–] qaz@lemmy.world 14 points 2 months ago

There are only 7 unit test classes. 2 of which I wrote myself this month.

[–] cheddar@programming.dev 29 points 2 months ago (1 children)

Somebody should tell Albert and the others, they can let this method go.

[–] qaz@lemmy.world 29 points 2 months ago* (last edited 2 months ago) (2 children)

I already did so an hour ago

UPDATE: It has been merged

[–] AdNecrias@lemmy.pt 31 points 2 months ago

https://xkcd.com/1172

You know it's comming.

[–] cheddar@programming.dev 13 points 2 months ago

Alright, this is my first contribution to an open-source project, albeit indirect. I'll drink to that!

[–] Endmaker@ani.social 34 points 2 months ago (1 children)

Any context?

[–] qaz@lemmy.world 58 points 2 months ago (1 children)

Found it while refactoring KDE Connect Android.

[–] beepnoise@piefed.social 39 points 2 months ago (2 children)

Found the masterpiece: https://github.com/KDE/kdeconnect-android/blob/d41ed4d911959beef923d0d9a9c74072f0dd920a/src/org/kde/kdeconnect/Helpers/StorageHelper.java#L56

[–] Traister101@lemmy.today 6 points 2 months ago

Wow, that looks like a nightmare

[–] 30p87@feddit.org 3 points 2 months ago

It has a typo

Me about to make my first contribution to KDEConnect Ü

[–] hades@lemm.ee 21 points 2 months ago

Ah yes, that's Android for ya.

[–] pfm@scribe.disroot.org 6 points 2 months ago

I keep telling myself that in the ideal world, phones would be programmed in Forth.